Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for GCC 15 givaro bug #241

Closed
wants to merge 1 commit into from

Conversation

d-torrance
Copy link
Member

I think this should fix Macaulay2/M2#3507 for our macOS GitHub builds since they use the homebrew package.

@mahrud
Copy link
Member

mahrud commented Oct 3, 2024

Could you add build 1 after revision 1.

@d-torrance d-torrance force-pushed the givaro branch 2 times, most recently from 25539e3 to 5fb15ab Compare October 4, 2024 00:30
@d-torrance
Copy link
Member Author

The builds failed with build 1 (wrong number of arguments (given 1, expected 0)), so I tried bumping revision to 2, and that seems to be working. Was that ok?

@mahrud
Copy link
Member

mahrud commented Oct 4, 2024

No, we don't want to force an update on everyone (or worse, break linkage).

@mahrud
Copy link
Member

mahrud commented Oct 4, 2024

I guess the previous version without revision or build number was correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal error: no member named 'Low' in 'rint<K>'
2 participants